daveshanley / vacuum

vacuum is the worlds fastest OpenAPI 3, OpenAPI 2 / Swagger linter and quality analysis tool. Built in go, it tears through API specs faster than you can think. vacuum is compatible with Spectral rulesets and generates compatible reports.
https://quobix.com/vacuum
MIT License
580 stars 48 forks source link

Regression detecting duplicate parameters #440

Closed TristanSpeakEasy closed 8 months ago

TristanSpeakEasy commented 8 months ago

A spec with duplicate parameters used to return an error from GetOperationParametersIndexErrors like: "the get operation parameter at path /test, index 1 has a duplicate name action and in type"

but this no longer returns anything for a spec with parameters like so:

openapi: 3.0.0
servers:
  - url: http://localhost:8080
paths:
  /test:
    get:
      parameters:
        - name: action
          in: query
          schema:
            type: string
        - name: action
          in: query
          schema:
            type: string
daveshanley commented 8 months ago

Running this exact spec through vacuum v0.8.7 produces this result:

Screenshot 2024-02-03 at 1 50 18 PM

The rules are working as expected in v0.8.7