daveshap / OpenAI_Agent_Swarm

HAAS = Hierarchical Autonomous Agent Swarm - "Resistance is futile!"
MIT License
2.98k stars 380 forks source link

Proposal for Repository Restructuring V1.1 #98

Closed RomanGoEmpire closed 11 months ago

RomanGoEmpire commented 11 months ago

Here is the revised restructuring, now incorporating the recent modifications made by the toolmaker. I didn't handle many forks and pull requests before, which led to some mistakes. This represents the updated iteration of #79.

RomanGoEmpire commented 11 months ago

@OWigginsHay is tool_demo.py (the file was in root before) still needed ?

OWigginsHay commented 11 months ago

Hi @RomanGoEmpire not it is not. Also a previous PR from someone removed an important folder. I have a hotfix on my branch which is synced with the current main in the repo. Go ahead and force PR as needed and after todays PRs are closed, I will apply the hotfix for tools

OWigginsHay commented 11 months ago

@RomanGoEmpire unless this PR is still a work in progress, at which point I will apply my hotfix now so up-to-date forkers can run the code error free

RomanGoEmpire commented 11 months ago

@RomanGoEmpire unless this PR is still a work in progress, at which point I will apply my hotfix now so up-to-date forkers can run the code error free

From my side it is done. I would like to standardize the structure of each agent but the "problem" is that the whole code of Agent builder is centered around the file structure it currently has. I think to edit tool-maker structure is way easier (move all files into a folder that dont have a main() function

RomanGoEmpire commented 11 months ago

@OWigginsHay If you are okay with the current state you can merge it.

OWigginsHay commented 11 months ago

@OWigginsHay If you are okay with the current state you can merge it.

You are referring to this PR or my hotfix. I'm assuming you mean you are done with this but I want to double check

OWigginsHay commented 11 months ago

IMO getting decent project structure is going to be important, especially while the other PRs are small and conflict won't be too bad! So I want to get this in ASAP

RomanGoEmpire commented 11 months ago

please update the current main branch with your hotfix. I will update my PR then

OWigginsHay commented 11 months ago

Marged. You can fix the conflict and I will merge this.

RomanGoEmpire commented 11 months ago

should be the code_of_conduct.md in documentation or in root?

OWigginsHay commented 11 months ago

I would say code of conduct should be root, along with the main README which seems to be missing? The one that appears at the front of the github page

RomanGoEmpire commented 11 months ago

I would say code of conduct should be root, along with the main README which seems to be missing? The one that appears at the front of the github page

image

The README is in Root

RomanGoEmpire commented 11 months ago

Also I am not sure why it still says that there are conflicts. chat_manager is the same

OWigginsHay commented 11 months ago

Sorry, I was reading the commit diff.

RomanGoEmpire commented 11 months ago

It should be up to date now. With the current main branch and your hotfix

OWigginsHay commented 11 months ago

Looks good, I just can't tell why there is still a conflict with that file

RomanGoEmpire commented 11 months ago

I moved the imports around(because of my formatter).The conflict was already before. Can you try to resolve it with the button here on github?

RomanGoEmpire commented 11 months ago

Now it is done. I understood how to merge the incoming changes 😅