Fix typo - Githubissues

davesmith4398 / best_practice_membranes

Best Practices document to be submitted to the Living Journal of Computational Molecular Science

Creative Commons Attribution 4.0 International

5 stars 2 forks source link

Fix typo #10

Closed mimischi closed 5 years ago

mimischi commented 5 years ago

The introduction contains a small typo, leading to a line break in the .tex file. I'm still reading and will update the PR if I discover anything else.

mrshirts commented 5 years ago

IF you can fix this today @davesmith4398, I think we can still get it into the final version for the issue.

mimischi commented 5 years ago

I just finished reading and pushed all commits. If necessary, I can group all/related commits by squashing.

Some more things that caught my eye, but might only be nitpicking:

A full stop is sometimes added to list items (compare checklist on page 14 and Tables 1-3)
Whitespace is sometimes added before and after a / (forward slash), but omitted other times (i.e. Table 3)
"X-ray" is written in lowercase ("x-ray") most of the time, but once as "X-ray" (bottom, Table 1). I don't know if there is any "correct" convention.

davesmith4398 commented 5 years ago

Hi @mimischi - Thank you very much for your edits and suggestions. We have accepted all of your edits. In terms of your additional suggestions:

(1) For consistency, we have added full stops to all list items in the checklist, but not in the tables. (2) We have eliminated all white space immediately before and after forward slashes. (3) Per certain bibliographic guidelines, we have eliminated capitalization on the one "X-ray" instance.

@mimischi and @orbeckst - If/when you locate the appropriate lipidbook link, please let us know, and we will make the update. Thank you!

@mrshirts - The appropriate files (including published version 1) should be updated per this conversation.

mimischi commented 5 years ago

@davesmith4398 Lipidbook is online again, as per https://github.com/davesmith4398/best_practice_membranes/pull/10#discussion_r246194620, and available at https://lipidbook.bioch.ox.ac.uk/.