search

davesnx / styled-ppx

Type-safe styled components for ReScript, Melange and native with type-safe CSS
https://styled-ppx.vercel.app
BSD 2-Clause "Simplified" License
400 stars 32 forks source link

add server-rr to deps #364

Closed jchavarri closed 10 months ago

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **styled-ppx** | ⬜️ Ignored ([Inspect](https://vercel.com/davesnx/styled-ppx/GwFzk6wvPnhmPPkWDGYxeUt163qn)) | [Visit Preview](https://styled-ppx-git-fork-jchavarri-add-server-rr-to-deps-davesnx.vercel.app) | | Oct 24, 2023 1:19pm |
davesnx commented 10 months ago

That's not required since it's pinned and the opam worflow isn't polished

jchavarri commented 10 months ago

@davesnx This was helpful to avoid issues while installing styled-ppx in ahrefs monorepo, where opam would start installing styled-ppx before the required version of server-rr was available.

since it's pinned

The fact that SRR is pinned is orthogonal to having the package added to styled-ppx depends field. The suggested fix just helped opam establish the ordering in which packages have to be installed.

davesnx commented 10 months ago

Sure it should be added on the opam's monorepo but not in this opam file yet. It won't install here

jchavarri commented 10 months ago

I see what you mean. When creating the switch, this addition would be problematic because it would point to a version dev of SSR that opam wouldn't know about.

In that case, maybe pin-depends should be used rather than manual pinning through Makefile commands? I think it's good to have a version of the opam file of styled-ppx that we can just copy/paste into the monorepo over time (rather than copying the latest, and then try to remember what things we have to add....)