davesnx / styled-ppx

Type-safe styled components for ReScript, Melange and native with type-safe CSS
https://styled-ppx.vercel.app
BSD 2-Clause "Simplified" License
400 stars 32 forks source link

Remove lexbuffer in favor of sedlex #369

Closed lubegasimon closed 10 months ago

lubegasimon commented 10 months ago

Changes made:

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **styled-ppx** | ⬜️ Ignored ([Inspect](https://vercel.com/davesnx/styled-ppx/7faJh8nydQZpagdQ1CJ2tuvqiLJB)) | [Visit Preview](https://styled-ppx-git-fork-lubegasimon-remove-lexbuffer-02cce7-davesnx.vercel.app) | | Nov 16, 2023 0:21am |
lubegasimon commented 10 months ago

Have you tried updating sedlex to latest?

Yes, in my switch v3.2 is installed (which is the latest in opam).

davesnx commented 10 months ago

Can you add it on the .opam file?

lubegasimon commented 10 months ago

Can you add it on the .opam file?

Done in https://github.com/davesnx/styled-ppx/pull/375

lubegasimon commented 10 months ago

I would like to merge this, but before that can you add a tests for an error of the parser?

I believe this will be very beneficial while we change the location and container_lum.

I guess this is resolved here https://github.com/davesnx/styled-ppx/pull/369/commits/fcc87416f6604b75d2b905c2ab74e8f995a6b347