search

davesnx / styled-ppx

Type-safe styled components for ReScript, Melange and native with type-safe CSS
https://styled-ppx.vercel.app
BSD 2-Clause "Simplified" License
399 stars 32 forks source link

Add `styled-ppx-native` package #409

Closed jchavarri closed 5 months ago

jchavarri commented 7 months ago

A couple of people in the Melange community have reported some issues while installing styled-ppx after the addition of the OCaml native side for universal components (mostly server-reason-react).

I think it's nice to keep styled-ppx "free" of any native OCaml deps like server-reason-react, pcre etc, for those users that only need to run it with Melange in browser environments.

This PR adds a new package styled-ppx-native that only includes the native parts of it, and removes the server-reason-react dep from styled-ppx package.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **styled-ppx** | ⬜️ Ignored ([Inspect](https://vercel.com/davesnx/styled-ppx/dbvhKoBM24HipfH4BoBAvRPxZNwc)) | [Visit Preview](https://styled-ppx-git-fork-jchavarri-styled-ppx-native-pkg-davesnx.vercel.app) | | Jan 24, 2024 8:37am |
lubegasimon commented 7 months ago

A couple of people in the Melange community have reported some issues while installing styled-ppx after the addition of the OCaml native side for universal components (mostly server-reason-react).

LGTM, for example, what issues?

jchavarri commented 7 months ago

what issues?

mostly problems when installing styled-ppx on macos, due to the dependency on pcre (which also requires pkg-config).

davesnx commented 5 months ago

Closing this, since I want to polish the instalation for Melange and native in one go. If it causes issues after the polishment, I will reborn the idea of separate packages