search

davesnx / styled-ppx

Type-safe styled components for ReScript, Melange and native with type-safe CSS
https://styled-ppx.vercel.app
BSD 2-Clause "Simplified" License
399 stars 31 forks source link

Stylesheet comments parsed incorrectly #442

Closed zakybilfagih closed 4 months ago

zakybilfagih commented 4 months ago

441

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **styled-ppx** | ⬜️ Ignored ([Inspect](https://vercel.com/davesnx/styled-ppx/Huv64DWd8BY8RKGrj3kPU4gaJvLj)) | [Visit Preview](https://styled-ppx-git-fork-zakybilfagih-parse-stylsheet-60ee1d-davesnx.vercel.app) | | Mar 12, 2024 4:58pm |
zakybilfagih commented 4 months ago

Setting skip_whitespace on parse_stylesheet seems to fix the issue

davesnx commented 4 months ago

That's a nice fix, by default we were parsing only one style rule, so I asumed skipping whitespaces was needed. No it isn't anymore 👍🏼

zakybilfagih commented 4 months ago

Found another problem, seems like a bug with skip_whitespace tez123