davesnx / styled-ppx

Type-safe styled components for ReScript, Melange and native with type-safe CSS
https://styled-ppx.vercel.app
BSD 2-Clause "Simplified" License
399 stars 31 forks source link

Replace usages of `j` and `js` quoted strings with ones without id #479

Closed jchavarri closed 3 weeks ago

jchavarri commented 4 weeks ago

In https://github.com/ml-in-barcelona/server-reason-react/pull/139, server-reason-react is starting to fail if it finds j or js in quoted strings for code that uses melange.ppx.

Using that patch, I noticed some of the code in styled-ppx was using these quoted strings, but there's no unicode or any interpolation, so it can just use quoted strings without id {||}.

The diff is long, but the process was mostly find and replace on the affected files, nothing else. I originally started using regular strings, but found a few places where double quotes are used, so I feel safer by keeping the same literals without having to escape.

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **styled-ppx** | ⬜️ Ignored ([Inspect](https://vercel.com/david-sanchos-projects-8c534635/styled-ppx/ByxxiSEWLLZbDUF8kzf884wfQoQx)) | [Visit Preview](https://styled-ppx-git-remove-us-253d1f-david-sanchos-projects-8c534635.vercel.app) | | Jun 20, 2024 6:08am |
jchavarri commented 3 weeks ago

Closing this as not necessary anymore, see https://github.com/ml-in-barcelona/server-reason-react/pull/139#issuecomment-2180873831.