search

davesnx / styled-ppx

Type-safe styled components for ReScript, Melange and native with type-safe CSS
https://styled-ppx.vercel.app
BSD 2-Clause "Simplified" License
400 stars 32 forks source link

Handle var() globally #504

Open zakybilfagih opened 1 month ago

zakybilfagih commented 1 month ago

Closes #417, we handle this the same way as cascading values. If we detect the use of var(), it will be unsafe and the value will be rendered as string.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **styled-ppx** | ⬜️ Ignored ([Inspect](https://vercel.com/david-sanchos-projects-8c534635/styled-ppx/4DbjGohDX3d6kxMKFtPwmKwqhGqG)) | [Visit Preview](https://styled-ppx-git-fork-zaky-453b44-david-sanchos-projects-8c534635.vercel.app) | | Aug 11, 2024 0:41am |
zakybilfagih commented 1 month ago

I see your point, I think we can put them exactly the same place as we put on them Parser grammar. I also have some thoughts on how we place <interpolation> on the grammar, will create an issue abt that.