search

davesteele / comitup

Bootstrap Wifi support over Wifi
https://davesteele.github.io/comitup/
GNU General Public License v2.0
322 stars 54 forks source link

Add custom zeroconf service name, option to load config from /boot directory #135

Closed d8ahazard closed 3 years ago

d8ahazard commented 3 years ago

Pretty straightforward...

Add an option to put "service_name" in comitup.conf, which will then be read and injected into the MDNS service advertiser for zeroconf. Tested and works perfect for my service "_glimmr._tcp". Made sure to keep the default as "workstation" to not break existing instances.

Also, add a check before loading the config that looks for /boot/comitup.conf, and if detected, copies it over the existing config in /etc/comitup.conf and then deletes the config from /boot. This is similar to how Rpi does wifi autoconfig now, and I think would be the perfect finishing touch for the full flashable image. ;)

d8ahazard commented 3 years ago

Closing, cleaned up commits and rebased...

davesteele commented 3 years ago

Do you mean for this to be closed?

d8ahazard commented 3 years ago

Do you mean for this to be closed?

I did. I accidentally commited the venv directory the first time around - so I cleaned up, closed this, rebased, and re-opened as a clean commit, #136.

After looking at the notes on the other open PR, I figured I'd just do it neat the first time around...