davesteele / comitup

Bootstrap Wifi support over Wifi
https://davesteele.github.io/comitup/
GNU General Public License v2.0
324 stars 55 forks source link

Crashed by apostrophe #211

Closed rendo0m closed 2 years ago

rendo0m commented 2 years ago

Hello David, the pynab project comes with comitup. Very easy if you don't own or having a wifi with an "apostrophe" in your range. Maybe you can review my changes, that made everything work for me. :-) Thanks for your work!

wspi commented 2 years ago

That didn't fix #212

I'll try some code changes due to the SSID with apostrophe to see if it's the same issue, or try in a place where this SSID is out of range to verify if it's the same issue

wspi commented 2 years ago

after some tests, it did indeed worked, not sure if it was another SSID that it's not present anymore, but there is one SSID with apostrophe and applying this changes worked, although I've tested without the change in line 87 and it's still working after reboot

davesteele commented 2 years ago

Thanks to both of you.