davesteele / comitup

Bootstrap Wifi support over Wifi
https://davesteele.github.io/comitup/
GNU General Public License v2.0
322 stars 54 forks source link

PYTHONPATH problem during development (title changed by maintainer) #39

Closed DaleMitchell closed 5 years ago

DaleMitchell commented 5 years ago

I tried running comitup from the command line:

ImportError: cannot import name persist

@davesteele, when was the last time you tried running setup.py on a fresh image of Raspbian? It appears that many things are broken due to poor maintenance of the GitHub repo.

davesteele commented 5 years ago

I've probably never run setup.py on Raspbian. It serves as a config file for the debian build. There are a number of installation tasks required that are not well suited for setup.py.

Try the deb file.

davesteele commented 5 years ago

It occurs to me that you may not have seen the home page.

DaleMitchell commented 5 years ago

Sorry if I came across as grouchy earlier, didn't get enough sleep.

I have seen the homepage, it sets high expectations for the software that I like, but I'm frustrated that I'm getting these errors with the Python files in the master repo! If I had a fix, I wouldn't hesitate to make a pull request for the benefit of others.

On Fri, May 10, 2019, 11:58 AM David Steele notifications@github.com wrote:

It occurs to me that you may not have seen the home page https://davesteele.github.io/comitup/.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davesteele/comitup/issues/39#issuecomment-491339904, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3T7ORKZOSVQJ4TW7RD2JLPUWLR5ANCNFSM4HMBFX7A .

davesteele commented 5 years ago

You pretty much have to have a deb install for the environment to work. For development after that, I use a small deploy script to scp the project tree from a remote computer to a local project tree, and then copy the files to the individual subdirectories in /usr/share/comitup/. The last step could be skipped with some work to address the path problem you're seeing. But, I prefer to edit the project on a remote system, which means that some sort of custom deploy process is required for me.

DaleMitchell commented 5 years ago

Okay... so the setup.py doesn't really do what people expect it to do?

There's more configuration that needs to be done beyond running setup.py build and setup.py install?

Why don't we have setup.py do everything that needs to be done?

davesteele commented 5 years ago

setup.py is intended to be cross platform, and currently does that job. The .deb file is specifically targeted to a particular OS, and can be uninstalled.

It sounds like you need to go find the tool that is right for you.

DaleMitchell commented 5 years ago

Then why do I get:

ImportError: cannot import name persist

After running build and install with setup.py if it currently does the job?

davesteele commented 5 years ago

Because there is a PYTHONPATH problem. You are welcome to attack that, if you wish. Or, you can vote with your feet.

DaleMitchell commented 5 years ago

Why did you close an issue that isn't fixed? This issue doesn't have to do with a premade image.