davesteele / gnome-gmail

Integrate GMail into the Linux Desktop
https://davesteele.github.io/gnome-gmail/
GNU General Public License v2.0
50 stars 13 forks source link

The appdata description field is not being translated. #64

Closed davesteele closed 7 years ago

davesteele commented 7 years ago

The appdata description field is not being translated.

Tagging the _p tag for translation is apparently wrong.

See the Polish translation.

davesteele commented 7 years ago

An outside assessment:

The file itself looks fine, I only get these validation issues:

I - gnome-gmail.appdata.xml:gnome-gmail.desktop:4 The id tag for "gnome-gmail.desktop" still contains a 'type' property, probably from an old conversion.

W - gnome-gmail.appdata.xml:gnome-gmail.desktop:4 The component ID is not a reverse domain-name. Please update the ID and that of the accompanying .desktop file to follow the latest version of the Desktop-Entry and AppStream specifications and avoid future issues.

Validation failed: warnings: 1, infos: 1 (you might want to fix those - if you change the ID, you will want to add a tag, so your app is still launchable)

I don't know exactly what is wrong with itstool, that should just work like that. However, it might be a good idea in general to switch to modern Gettext instead at this point. If you remove all the itstool underscore markings, and just run xgettext gnome-gmail.appdata.xml -o /tmp/test.pot it will do the right thing (if it doesn't, your xgettext is too old and you don't have AppStream installed - newer Gettext versions won't need AppStream to be installed).

davesteele commented 7 years ago

This is not going to be addressed - see https://github.com/ximion/appstream/issues/134.