Add option use_browser, update config comments for newer browser options

davesteele / gnome-gmail

Integrate GMail into the Linux Desktop

https://davesteele.github.io/gnome-gmail/

GNU General Public License v2.0

50 stars 13 forks source link

Add option use_browser, update config comments for newer browser options #72

Closed groovenectar closed 5 years ago

groovenectar commented 5 years ago

I like to use Firefox as the default, and Chrome for Google Apps like Gmail.

This adds an option called "use_browser" to the config. If nothing is specified, then it still uses the value of xdg-settings get default-web-browser. One other update to this is the comment section of the config. It seems that the default browser options have been updated, and the comments now reflect that. Also, %s is changed to %%s to avoid confusion if someone does not know about the escaping.

groovenectar commented 5 years ago

I'm not sure if this is an issue with recent changes to Gmail or related to the code I added, but I just noticed something... When I open an email link from a webpage... It goes to the Drafts folder and has saved a new draft with the mailto from address, but it isn't opening the compose screen... I don't believe that what I added would affect the compose mechanism, so there may be something else going on...

Tested in Linux Mint / Google Chrome

davesteele commented 5 years ago

You are correct. With the new Gmail, there is no apparent way to open a computer window via URL.

I'm away from my computer this week. I'll try to get to this for the weekend.

davesteele commented 5 years ago

Looks fine. Rebased onto master.

Thanks.