search

davestewart / alias-hq

The end-to-end solution for configuring, refactoring, maintaining and using path aliases
https://davestewart.co.uk/projects/open-source/alias-hq/
MIT License
333 stars 12 forks source link

Add support for tsconfig extends #37

Closed IanVS closed 3 years ago

IanVS commented 3 years ago

This uses the native typescript utilities for reading and parsing a config file, which means that comments and trailing commas are supported, as well as extending from another config.

I needed to break out a helper function to log messages, since the parsing is slightly different between package.json and config files now, but they can share the same error handling, I think.

I also created a few basic tests for loading config files with comments and commas, as well as extending from other configs. Let me know if you'd like to see more.

Closes #28 Closes #30

davestewart commented 3 years ago

Looks good!

It's late here so I'll take a look tomorrow.

Thanks :)

davestewart commented 3 years ago

OK, linting now added so you'll want to merge and run npm run lint.

IanVS commented 3 years ago

Updated to address linting issues

davestewart commented 3 years ago

No idea what these errors are about. Any ideas?

EDIT: seems to be a build pipeline permissions thing.

I ran the checks locally and it's all good, so going to merge 👍