search

davestewart / app-diary

Ongoing development diary of building a Trello clone
https://davestewart.github.io/app-diary
32 stars 7 forks source link

Difficulty dragging boards on some mobiles #1

Open bovas85 opened 6 years ago

bovas85 commented 6 years ago

I can't move boards left to right, only right to left.

This is when opening the demo link

davestewart commented 6 years ago

Hmm. I can't reproduce that!

Is this on a particular OS/Browser?

EDIT 1: Ah - just seen the word "mobile" in the title. Can you provide more info? EDIT 2: Just tried on Pixel 2 / Chrome and it works just like the desktop

I use this lib for the DnD: https://github.com/kutlugsahin/vue-smooth-dnd

bovas85 commented 6 years ago

I have a OnePlus 5 with latest chrome.

I'm trying to drag the first board to the right, which works, but the anchor point threshold is perhaps too far and it comes back to the starting point.

davestewart commented 6 years ago

Hmm. That's going to be difficult for me to reproduce! 😢

Could be a great opportunity for your first PR! Either here, or I suspect in the library I mentioned above.

davestewart commented 6 years ago

So the author of Smooth DnD has a demo page.

Want to try that and see how your phone copes?

bovas85 commented 6 years ago

Yeah I think the actual lib is broken on mobile, at least at my size and phone, which is quite common.

Does it work for you and your phone when dragging stuff?

bovas85 commented 6 years ago

maybe worth looking at other options? https://github.com/vuejs/awesome-vue#drag-and-drop

davestewart commented 6 years ago

Does it work for you and your phone when dragging stuff?

Yeah, no problems at all!

maybe worth looking at other options?

If you check the diary, you'll see I tried a bunch of them, and actually Vue Smooth DnD was the one I ended up at:

I actually love how it works, but it's unfortunate it doesn't work on all phones.

Given that this is open source, and all the interface and store work has already been done, do you fancy looking at it!?

After all, the project exists online as a learning exercise; for me - rapid prototyping, for others - whatever suits them!

bovas85 commented 6 years ago

Yes I will clone and contribute. There's surely a threshold somewhere that we can fine tune

davestewart commented 6 years ago

Yes I will clone and contribute.

Though saying that, it could be useful to create an issue on the Vue Smooth DnD repo first.

If it's a known issue, that saves you some work. If it's an unknown issue, maybe they can fix it?

bovas85 commented 6 years ago

yes that's the intention, they have the bug on their demo itself.

You can actually check yourself by inspecting element, simulating mobile size (I tried around 320px) and trying to drag the whole board to the right.

davestewart commented 6 years ago

Oh yeah, that's weird. Every time I try to drag the screen pans!