search

davestewart / vuex-pathify

Vue / Vuex plugin providing a unified path syntax to Vuex stores
https://davestewart.github.io/vuex-pathify
MIT License
1.37k stars 57 forks source link

Vuex-pathify causing warnings when imported into Vue 3 (Quasar v2) project #128

Open skmbr opened 3 years ago

skmbr commented 3 years ago

Describe the bug As soon as I import vuex-pathify anywhere I see this warning in the console, always four times in a row:

 warning  in ./node_modules/vue-class-component/dist/vue-class-component.esm.js

"export 'default' (imported as 'Vue') was not found in 'vue'

 warning  in ./node_modules/vue-class-component/dist/vue-class-component.esm.js

"export 'default' (imported as 'Vue') was not found in 'vue'

 warning  in ./node_modules/vue-class-component/dist/vue-class-component.esm.js

"export 'default' (imported as 'Vue') was not found in 'vue'

 warning  in ./node_modules/vue-class-component/dist/vue-class-component.esm.js

"export 'default' (imported as 'Vue') was not found in 'vue'

Expected behaviour No warnings in the console

Additional context I've found similar posts from users of vue-bootstrap that suggest that package doesn't support vue 3 yet. Is this the case here?

Here's an example of a user having a similar problem with vue-bootstrap: https://stackoverflow.com/questions/63768491/export-default-imported-as-vue-was-not-found-in-vue

davestewart commented 3 years ago

Hi @skmbr,

Sorry for the delay in getting back to you.

It does not, yet. I should find time to do this officially but I'm stretched on other projects right now.

I'm hoping to hit some milestones in the next couple of weeks though, and then I think I should take some time to look at this.

There was a decision made a while back to make Vue Class Component a dependency of Vuex Pathify a while ago; I will probably need to look at that again (it wasn't really my area, and ended up being a community PR).

Is this a blocker for you in the meantime? Did you manage to make it work in Vue 3?

Click the label to see all Vue 3-related posts.

skmbr commented 3 years ago

Hi @davestewart ,

No worries, thanks for getting back to me!

Apart from the warnings it all seems to be working fine! Since they are just warnings it shouldn't be a major blocker, and I'm probably at least a month away from releasing this version of my app, but I thought it would be worth raising - even if (or especially if) it led to me finding out I was just doing something stupid! :)

Thanks again, and thanks for all your work!

davestewart commented 3 years ago

No worries! And thanks for letting me know anyway :)

Feel free to bug me if I don't make any updates 😬

skmbr commented 3 years ago

Will do! But not too soon! :)

NGPixel commented 3 years ago

@skmbr See https://github.com/davestewart/vuex-pathify/issues/130#issuecomment-926991066