search

davestewart / vuex-pathify

Vue / Vuex plugin providing a unified path syntax to Vuex stores
https://davestewart.github.io/vuex-pathify
MIT License
1.37k stars 57 forks source link

Add initial functional tests #73

Closed axwalker closed 5 years ago

axwalker commented 5 years ago

General Approach

I think the most valuable tests to add initially are functional tests, so I've started with some for store helpers and store accessors:

I've tried to keep things as simple as possible for now. Would rather get everything tested before delving into too many edge cases, and also want to check you're happy with the general approach!

Some other comments

GitHub actions: Are you signed up the Github Actions beta by any chance? I believe it's free for open source projects. If so, I can setup the tests to run for every future PR.

Code style: I think I've kept it roughly to match the existing code. Have you used a linter before? I appreciate this library is fairly stable by now so you might not be wanting to add/change too much!

npm audit: There are currently 11 high severity vulnerabilities in the packages dependencies - might be worth fixing this elsewhere (should be able to do it with npm audit fix). I think it's mostly related to a lodash issue from a few weeks ago.

Related issue: https://github.com/davestewart/vuex-pathify/issues/4

davestewart commented 5 years ago

Hey Andrew, this is brilliant!

Yes, agree with overall approach.

I can write a list of all the tests I think we want, and stub them out if needs be.

Other comments

GitHub actions: I've signed up, will let you know when I get the OK

Code style: Yes, I need to set up linting. I generally use Standard these days, with a couple of rule changes for cuddles if/else and maybe trailing commas, I can't remember off the top of my head!

npm audit: fixed and pushed! There's always some complaint...

Lastly - will be happy to buy you a beer at some point! Do you go to the London Vue meetups?

axwalker commented 5 years ago

Cool, I'm happy to continue writing more tests.

Went to the Vue conference last year in London, but not yet booked our tickets for this year. Will be sure to give you a shout if we're going!