davetcc / tcMenu

Menu library for Arduino, mbed and ESP with designer UI and remote control capabilities.
https://www.thecoderscorner.com/products/arduino-libraries/tc-menu/
Apache License 2.0
271 stars 25 forks source link

i18n feature is buggy #419

Closed vzahradnik closed 6 months ago

vzahradnik commented 7 months ago

Describe the bug i18n language support in designer is buggy. For example, I create a new text menu item, give it a name, then I hit on Save, and the name changes to "New variable". There is more...

To Reproduce Activate i18n support by adding at least one extra language, try to modify the menu items.

davetcc commented 7 months ago

I'll be creating a beta in a few days, it contains quite a few fixes along with the file watcher support. Let's keep this open until the i18n flow is at least fully workable.

vzahradnik commented 7 months ago

Latest branch behaves better but I still found at least one issue.

To reproduce:

  1. Add a new submenu item
  2. Change the submenu item text
  3. Save the project

=> Submenu item text should be discarded and changed to New SubMenu.

Attaching a video.

https://github.com/davetcc/tcMenu/assets/4460766/93ba14ed-5529-4c8e-bc76-2971bc143779

davetcc commented 6 months ago

I'm going to close this for now, I believe most of the issues to be resolved by the simplification project, but if you find anything else, raise a new issue for the specific issue.