search

davetron5000 / optparse-plus

Start your command line scripts off right in Ruby
http://davetron5000.github.com/optparse-plus
Apache License 2.0
521 stars 54 forks source link

Nitpicky logging change. #53

Closed yoni closed 11 years ago

yoni commented 11 years ago

Replace "Error output of" with "stderr output of" to ensure that folks know there's not actually any error.

This was especially annoying when writing a wrapper around Hadoop components. They log everything to stderr, so I kept seeing "Error", even though everything was working fine.

davetron5000 commented 11 years ago

Made a similar change for stdout and it turns out the tests were expecting that exact phrase. Updated them.

Which makes me think maybe there should be a way to configure those strings, but that's for another time.

Once this passes on Travis, I'll bump the version.

Thanks! Hadoop! Crazy! Can't believe they don't insist on Python :)

yoni commented 11 years ago

Awesome. Thanks Dave.

lol. This whole time I was under the impression that Travis was a person and that Travis was really nitpicky about log messages. ^_^

davetron5000 commented 11 years ago

build passing, this will be in the next release