search

davetron5000 / optparse-plus

Start your command line scripts off right in Ruby
http://davetron5000.github.com/optparse-plus
Apache License 2.0
521 stars 54 forks source link

Some additional improvements to the scaffolder #79

Closed pjump closed 10 years ago

pjump commented 10 years ago

1) specifying --license NONE or not specifying a license used to result in a LICENSE.txt file with the MIT license in it (created by bundle gem--this file now gets deleted 2) regardless of the users license choice -- the generated gemspec still had spec.license = "MIT" in it (generated by bundle gem)--now corresponds to the selected license 3) bundle gem stages all of the scaffolding it generated. Since methadone does things on top of that, this results in a mixtures of staged and unstaged files--now everything gets staged.

Each change is self-contained.

davetron5000 commented 10 years ago

Thanks for doing this. I have a few minor comments, but otherwise this is great!

davetron5000 commented 10 years ago

Just realized this may address #50, which is awesome.

Can you look into the travis failure? Looks like for whatever reason on 1.9.2 it's not exited as expected in some cases. Let me know if you can't repro and I'll try to look into it myself

pjump commented 10 years ago

No problem. I'm learning from it. :) I ran the tests suites locally on all other C rubies mentioned in .travis.yml, but I couldn't get 1.9.2 to install. I see why it breaks from the logs, though. I'll fix it later today.

pjump commented 10 years ago

All green now (simply singed up for travis-ci too--didn't know it was that simple).

pjump commented 10 years ago

About issue #50, I personally think the automated git add is a good thing (if everything is added). It makes it very easy to do git diff and see what changes I've done since I first ran methadone

davetron5000 commented 10 years ago

Yeah, I agree re: #50. This looks good. Will merge and release here in a few…

davetron5000 commented 10 years ago

Live in 1.6.0 Thanks again

yoni commented 10 years ago

Nice work. Thanks @pjump