Closed pjump closed 10 years ago
Thanks for doing this. I have a few minor comments, but otherwise this is great!
Just realized this may address #50, which is awesome.
Can you look into the travis failure? Looks like for whatever reason on 1.9.2 it's not exited as expected in some cases. Let me know if you can't repro and I'll try to look into it myself
No problem. I'm learning from it. :) I ran the tests suites locally on all other C rubies mentioned in .travis.yml, but I couldn't get 1.9.2 to install. I see why it breaks from the logs, though. I'll fix it later today.
All green now (simply singed up for travis-ci too--didn't know it was that simple).
About issue #50, I personally think the automated git add
is a good thing (if everything is added). It makes it very easy to do git diff
and see what changes I've done since I first ran methadone
Yeah, I agree re: #50. This looks good. Will merge and release here in a few…
Live in 1.6.0 Thanks again
Nice work. Thanks @pjump
1) specifying
--license NONE
or not specifying a license used to result in a LICENSE.txt file with the MIT license in it (created bybundle gem
--this file now gets deleted 2) regardless of the users license choice -- the generated gemspec still hadspec.license = "MIT"
in it (generated bybundle gem
)--now corresponds to the selected license 3)bundle gem
stages all of the scaffolding it generated. Since methadone does things on top of that, this results in a mixtures of staged and unstaged files--now everything gets staged.Each change is self-contained.