davewx7 / citadel

A turn based strategy game based on the Anura engine
Other
98 stars 25 forks source link

Creatures with haste from Battlecry can't move without help. #145

Closed jollki closed 6 years ago

jollki commented 6 years ago

A newly summoned creature that receives haste from Battlecry won't get an opportunity to move unless another creature is able to move. Here's a relevant test case.

https://pastebin.com/NBvAxxq6

Summon a Green Adder and cast Battlecry (in either order). The adder won't animate to indicate unused movement points and the the advancement button will still say "End Turn." Summon a Savage Wolf and move it by clicking directly or pressing the move button and the snake will realize that it can move.

ghost commented 6 years ago

Can't reproduce. My guess is that @davewx7 fixed it already.

Can you @jollki follow up to confirm if it is fixed for you now or it is me that am failing to reproduce?

You are welcome to join the Argentum Age Discord server if you already have not.

sapientN3T commented 6 years ago

Just a quick note that I was able to observe the buggy behavior in a recent game. I had two freshly summoned units and cast battlecry. Only one of them got animated to indicate unused movement points. The other (a Rokh) did not. However when I click Move they both moved as expected.

ghost commented 6 years ago

@sapientN3T happened to me too. Recently. Maybe twice. I didn't write it down because the unit moved, but it wasn't showing the move intention animation.

jollki commented 6 years ago

Bug appears to be fixed. It was very reproducible for me and now everything works as expected. If everyone else is running the test as directed and not getting the bug then I think we can close it.

ghost commented 6 years ago

@sapientN3T I think https://github.com/davewx7/citadel/issues/145#issuecomment-341460629 is a different issue, I'm sure it is still there in master as I am writing, I think it is straightforward to reproduce, I think I can fix it and probably without breaking something else.

If you are not already trying, I advice you to try to fix it yourself.

If you don't already know why, when you are done you are going to know why.

sapientN3T commented 6 years ago

Fixed by https://github.com/davewx7/citadel/commit/8c721eb90114d5491b1196175f3c689ddd701f4b