search

davewx7 / citadel

A turn based strategy game based on the Anura engine
Other
98 stars 25 forks source link

Visual fix for `Battlecry`. #159

Closed ghost closed 6 years ago

ghost commented 6 years ago

Manages to fix this issue @sapientN3T reported in #145.

ghost commented 6 years ago

After knowing ; has less precendence than , had some more tries in order to reduce the lines of this PR a bit, but every time I was trying, the visual glitch fixed by https://github.com/davewx7/citadel/pull/159/commits/bed19ffef012aea71ea3498b502f4ea38d421ff5 was coming back. :man_shrugging:

sapientN3T commented 6 years ago

Fixed by https://github.com/davewx7/citadel/commit/8c721eb90114d5491b1196175f3c689ddd701f4b

Regarding the most recent comment, see https://github.com/anura-engine/anura/issues/271

ghost commented 6 years ago

I only checked it quickly, but most probably I like your idea better. 😁