search

davewx7 / citadel

A turn based strategy game based on the Anura engine
Other
97 stars 25 forks source link

Library UI overhaul #181

Closed HarryMichal closed 6 years ago

HarryMichal commented 6 years ago

I apologize for a lot of whitespace mess my editor did.

ghost commented 6 years ago

I apologize for a lot of whitespace mess my editor did.

Don't be. I think all the whitespace your editor wiped output is uninteresting. It's interesting to learn how to prevent this, though.

ghost commented 6 years ago
  • Filter buttons have changed brightness when mouse hovers over them.

That's nice, I'm seeing that with this change there is a more pleasant brightness change on hovering filters when a filter is active.

But there might be a little problem: with this change, there is no brightness change on hovering filters when no filter is active.

I don't think it is super important now, but maybe it can be changed a bit in order to still have brightness change when no filter is active.

Maybe something like, in the library_controller, in the spawning of the game_icon (line ~1350), to have it using one brightness value or a different one, depending on the status of library_controller#_school_filter (empty list or not).

HarryMichal commented 6 years ago

But there might be a little problem: with this change, there is no brightness change on hovering filters when no filter is active.

Yeah, I know what you're talking about. I just didn't know how to make it behave that way so I just left it like this. I was thinking about some border highlighting. Some kind of shine effect. That way we can prevent that unpleasant effect it had before the PR.