search

davewx7 / citadel

A turn based strategy game based on the Anura engine
Other
97 stars 25 forks source link

Fix too large window height. #203

Open Szunti opened 6 years ago

Szunti commented 6 years ago

Fixes #200

Szunti commented 6 years ago

Although if the wrong window sizes are saved already in ~/.citadel/preferences.cfg this won't help. Maybe you want a patch that works for old players too without having to delete that file.

ghost commented 6 years ago

This is pretty straightforward, or should be.

However, I tried this on my macOS computer, but there I couldn't find any window sizes in its preferences.cfg, and I couldn't see its Anura build executing that line (I used some dump(2) instructions for that), so from my side this is on hold until I can have my Linux computer at hand or have more information.

Unless gets merged, I'll try again from Plasma and, if necessary, from dwm too.

Cheers,

Szunti commented 6 years ago

Weird, I don't have those lines now either. I don't know what triggered it for me.

ghost commented 6 years ago

I ran Argentum Age on dwm and I think there the issue didn't reproduce. I might give awesome a chance, but not very likely...

Also this time again I couldn't run over the changed source doc!

I suspect there can be some code in the game that seems to be actual, but not being. Source dualities in tbs and citadel, mainly. I suspected this could be one of those... so far it seems it could be.

Cheers,

Szunti commented 6 years ago

I played citadel years ago once, maybe it wrote the lines into my config then? Width there instead of height is definitely wrong, but I don't know if this code is ever run in the current version.

ghost commented 6 years ago

I played citadel years ago once, maybe it wrote the lines into my config then? [...]

I can't tell.

Several years ago I played Frogatto 1.3 and 1.4-dev in such proportions that I ended up having ~/.frogatto/ not as real directory but as symlink to either ~/.frogatto-1.3/ or ~/.frogatto-master/ depending on the version in execution.

[...] Width there instead of height is definitely wrong, but I don't know if this code is ever run in the current version.

I don't know if this code is ever run nowadays either.

It's definitely wrong, but though in some propietary_software conditions I could care free about editing code maybe not effective; in this open source context, not being familiar enough with the doc as to know whether which one would be better between accepting the changes or closing the pull request without merging and spawning an issue to request the removal of apparently unreachable code, I have to yield the topic from here.

Cheers,