Extend supplementary character support

daveyarwood / djy

A library of character utility functions for Clojure

Eclipse Public License 1.0

37 stars 3 forks source link

Extend supplementary character support #6

Closed nibe closed 5 years ago

nibe commented 5 years ago

Character/toLowerCase, Character/toUpperCase and Character/toTitleCase support code points of supplementary characters so I removed the limitation to BMP using char'.

daveyarwood commented 5 years ago

Thanks for the PR! This seems like a good change to make. I think we should add a few test cases just to be certain that it works with characters above the BMP range.

nibe commented 5 years ago

There you go.

daveyarwood commented 5 years ago

Looks good, thanks again!

nibe commented 5 years ago

Thanks for the Clojars update!

(char/upper-case "𐐬") now returns "𐐄" instead of raising IllegalArgumentException: Value out of range for char: 66564, which will be useful for my project.