search

daveyc1234 / WebTechProject

fivesibsgolf repository
https://www.fivesibsgolf.me/
0 stars 0 forks source link

Peer Review- Yirong Shen #1

Open yshen12138 opened 1 year ago

yshen12138 commented 1 year ago

Hi, Dave, I like the idea your are making a website about yourself, but I do think you have a lot to work on still!

Technical issue: 1. Your selfie image is crushed because you don't have it in your image file. 2.Your "my work in web tech" link is not working because you don't have the document under your project folder.

  1. You haven't created links on your html page that navigate to your other pages. Content Issue: 1. you should work on the css more for example makes the links look identical to your texts, and adjust font-size to
    differentiate subtitles and content,
    1. The image breaks through your text which does not look good, may use table to organize it.
daveyc1234 commented 1 year ago

Hey yshen,

this is not my website. for some reason i still have my old page up and cannot update it.

i am talking to professor now

On Tue, Nov 8, 2022 at 11:17 AM yshen12138 @.***> wrote:

Hi, Dave, I like the idea your are making a website about yourself, but I do think you have a lot to work on still!

Technical issue: 1. Your selfie image is crushed because you don't have it in your image file. 2.Your "my work in web tech" link is not working because you don't have the document under your project folder.

  1. You haven't created links on your html page that navigate to your other pages. Content Issue: 1. you should work on the css more for example makes the links look identical to your texts, and adjust font-size to differentiate subtitles and content,
  2. The image breaks through your text which does not look good, may use table to organize it.

— Reply to this email directly, view it on GitHub https://github.com/daveyc1234/WebTechProject/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/A223UU3O7UDWDA5CJRCFWW3WHJ4IRANCNFSM6AAAAAAR2P6RJY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

daveyc1234 commented 1 year ago

It is now working

On Tue, Nov 8, 2022 at 11:46 AM Crouch, David @.***> wrote:

Hey yshen,

this is not my website. for some reason i still have my old page up and cannot update it.

i am talking to professor now

On Tue, Nov 8, 2022 at 11:17 AM yshen12138 @.***> wrote:

Hi, Dave, I like the idea your are making a website about yourself, but I do think you have a lot to work on still!

Technical issue: 1. Your selfie image is crushed because you don't have it in your image file. 2.Your "my work in web tech" link is not working because you don't have the document under your project folder.

  1. You haven't created links on your html page that navigate to your other pages. Content Issue: 1. you should work on the css more for example makes the links look identical to your texts, and adjust font-size to differentiate subtitles and content,
  2. The image breaks through your text which does not look good, may use table to organize it.

— Reply to this email directly, view it on GitHub https://github.com/daveyc1234/WebTechProject/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/A223UU3O7UDWDA5CJRCFWW3WHJ4IRANCNFSM6AAAAAAR2P6RJY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

daveyc1234 commented 1 year ago

If this helps, I know I need help on my table and maybe improving my navigation bar into a dropdown menu. Do you think you could help me there?