daveyholler / eui

Elastic UI Framework 🙌
https://elastic.github.io/eui/
Other
0 stars 1 forks source link

Make tokens have displayOptions #1

Closed snide closed 6 years ago

snide commented 6 years ago

Summary

Had some time (and felt bad for my lack of help over zoom). Cleaned up the props on the component and made it more flexible. Can discuss if you want a run-thru of the changes.

Stuff we should probably do still

image

cchaos commented 6 years ago

I agree with separating the icons into sections. I've been wanting to do that even with some of the other context specific icons. Also, can the list of named tokens be either alphabetical or something logical like grouping the different shapes together (since they seem to indicate a particular grouping).

daveyholler commented 6 years ago

I agree with these changes. I'll pull it down and have a further look. Thanks for all the help on this.

Regarding the docs, I think separating the tokens into their own section is a solid idea.