Closed snide closed 6 years ago
I agree with separating the icons into sections. I've been wanting to do that even with some of the other context specific icons. Also, can the list of named tokens be either alphabetical or something logical like grouping the different shapes together (since they seem to indicate a particular grouping).
I agree with these changes. I'll pull it down and have a further look. Thanks for all the help on this.
Regarding the docs, I think separating the tokens into their own section is a solid idea.
Summary
Had some time (and felt bad for my lack of help over zoom). Cleaned up the props on the component and made it more flexible. Can discuss if you want a run-thru of the changes.
displayOptions
prop for setting color, shape, and opaque/solidness (didn't like my name any better than yours!)Stuff we should probably do still
EuiToken
should probably have its own docs page and not be on the Icon page (maybe?). The new page should have two examplestoken*
icons in their own section within theEuiIcon
docs page. Right now they're smushed at the end when everything else is alphabetical. It might give us a better chance to explain them.opaque
andtokenTintXX
. I didn't have any better ideas but something feels weird. Naming is hard.token
.