davezych / shience

A .NET port(ish) of Github's Scientist library. (https://github.com/github/scientist)
MIT License
9 stars 1 forks source link

shience.tests does not use shience directly #14

Closed MovGP0 closed 8 years ago

MovGP0 commented 8 years ago

Shience.Tests downloads Shience from NuGet instead of targeting it directly. this way, changes cannot be tested immediately and the [assembly:InternalsVisibleTo("...")] attribute gets ignored.

davezych commented 8 years ago

Ha. How great. It's because the version on nuget is listed as 1.0.0-beta2, and tests are targeting 1.0.0-*.

I need to think about what to do about the version on Nuget right now. It's listed as beta2 just because I was just messing with project.json versioning. We really should roll back the version # to an alpha. 0.0.1-alpha or something.

MovGP0 commented 8 years ago

Thanks!

this is my first DNX project. I missed that one. will take a look on it next time.

davezych commented 8 years ago

I rolled back the version to 0.0.1, and set tests to target specifically that version so it should pull it down locally.

MovGP0 commented 8 years ago

I still experience the same issue. the project Shience.Test is not building, because it downloads the library from NuGet instead of using the local copy.

MovGP0 commented 8 years ago

Solution: the dependency in the test project must be given without version number to use the local version:

"dependencies": {
    "Shience": ""
  }