davfive / obsidian-jtab

jTab Guitar Codeblocks for Obsidian adds the ability to show guitar chords and tabs directly in your notes.
MIT License
65 stars 1 forks source link

Stop breaking shellcmd (#15) and Toggl Track (#10). #16

Closed davfive closed 4 months ago

davfive commented 4 months ago

Overview

Whenever this jTab plugin was installed, the shellcmd plugin's settings tab and Toggl Track plugin's queries would break (see #15 and #10 respectively)

Changes

Refactor original jTab library so it wasn't extending Array globally with Array.prototype.max_chars function. The fixes was to simply make an arrow function that didn't corrupt the global Array class.