davglass / zipcodes

Zipcode lookup node module
Other
157 stars 83 forks source link

Wrong return type of lookupByCoords(lat: number, lon: number) #48

Open bitcooker opened 1 year ago

bitcooker commented 1 year ago

The current lookupByCoords returns string | null. Is it correct?

image

It should be ZipCode | null

export function lookupByCoords(lat: number, lon: number): ZipCode | null;

bitcooker commented 1 year ago

I made a PR for it

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/65713