davibarreira / Vizagrams.jl

Integrating diagramming and data visualization
https://davibarreira.github.io/Vizagrams.jl/
MIT License
39 stars 1 forks source link

Check in Dark Mode #6

Open cormullion opened 1 month ago

cormullion commented 1 month ago

Looks pretty cool!

I suggest you have a quick look through the docs in Dark Mode - quite a few images need a background. since you’re using black ink a lot. 😀

davibarreira commented 1 month ago

@cormullion , what a pleasure to have you checking my package! Thanks a lot for the heads-up on the dark mode docs.

davibarreira commented 1 month ago

I've checked the docs for Gadfly. They actually leave without the white background. I was wondering whether it is a good idea to have the white background, cause it might lead people to think that such background is always present. The black color is the default in SVG, so changing the color would make the docs more verbose.

I've added the white background to some plots, but I'm thinking of leaving as it is in the other stuff. What do you think?

Just to be clear, every figure can have a white background by simply writing:

draw(plt, style="background-color:white")
cormullion commented 1 month ago

People often ask "How do I make the background transparent?" and "How do I make the background white?", so including these instructions explicitly wouldn't be a bad thing... I think verbosity isn't a bad thing in documentation, particularly if if saves someone asking on Discourse :)

If you use colours with medium Luminance, you can draw diagrams that are readable on both black or white backgrounds:

Screenshot 2024-07-15 at 18 23 26