Laravel 5 Compatibility

[ellisio]

Hello,

Me and my company are getting ready to integrate Push Notifications into our application. However, we are developing on Laravel 5. Is there an ETA on getting this updated to be compatible with L5?

Cheers, Andrew

[davibennun]

I havent played with laravel 5 yet, can you fork the repo and upgrade illuminate/support version constraint to "4.|5." and see if its ok?

[ellisio]

I'll take a peak this weekend for ya.

Sent from my iPhone

On Feb 5, 2015, at 5:22 PM, Davi Nunes notifications@github.com wrote:

I havent played with laravel 5 yet, can you fork the repo and upgrade illuminate/support version constraint to "4.|5." and see if its ok?

— Reply to this email directly or view it on GitHub.

[billmn]

To allows L5 support, need to change come code like configuration publishing ...

I propose to create a new branch dedicated to L5 version.

[nullproduction]

I'd like use this lib in laravel 5 too.

[kisPocok]

+1 upvote!

[asterism612]

+1

[torniker]

:+1:

[yvesroos]

👌

[Daniel-Seo]

+1

[gmatkowski]

+1

[kirant400]

+1

[indesignlatam]

+1

[davibennun]

Hello guys! Sorry for being late. Laravel 5 version is now available at laravel5 branch, you can require it on composer: "davibennun/laravel-push-notification": "dev-laravel5" The way you use this package is the same, the only thing changed was the config file location, once you published it using php artisan vendor:publish the config file goes to app/config/push-notification.php

[davibennun]

I don't have any certificate here to fully test the package, I think its ok since changes were very small, but you never know... can someone use it in real life just to make sure everything is working?

[gmatkowski]

i'll be able to test it in a few days, thx for creating v5 branch :-)

[nullproduction]

@davibennun Thank U. I will check this next week

[agarwalVinayak]

I am trying for Laravel 5. config:publish is not valid command

So for "Copy the config file into your project by running" php artisan config:publish davibennun/laravel-push-notification doesn't worked in Laravel 5

Instead this will work laravel 5 : php artisan vendor:publish --provider="Davibennun\LaravelPushNotification\LaravelPushNotificationServiceProvider" --tag="config"

This command will created config file in L5.

[davibennun]

@agarwalVinayak I just merged the pull request that updates the documentation.

[agarwalVinayak]

@davibennun cool!! , but still doc for L5 have composer.json path as "davibennun/laravel-push-notification": "dev-master" and not "davibennun/laravel-push-notification": "dev-laravel5"