search

davicorreiajr / spotify-now-playing

Spotify now playing information and control popup for macOS menu bar
MIT License
217 stars 11 forks source link

Open Browser For Facebook Auth #32

Open kaufmann42 opened 5 years ago

kaufmann42 commented 5 years ago

What are you reporting?

In which context are you running the app?

Mac OS Mojave V 10.14.2 Now Playing - 0.6.1

Description

I think it's a little bit sketchy to let a 3rd party application like this authenticate FB credentials within its own web-view. I know you guys aren't doing anything with nefarious, but it is a concern UX wise.

Also it's pretty annoying to have to fetch my credentials on FB / remember my password. Would be great if the app could open up the browser with the OAuth link and then poll the response.

paced commented 3 years ago

Agreed, I think this is a pretty important feature. I'd be keen to tackle this once my other three PRs are reviewed if nobody else wants to PR?

paced commented 3 years ago

@kaufmann42 I'm wary of hijacking a repo's issues page, however defunct, to discuss my own work, but my hard-fork Now Playing for Spotify has just resolved this in v0.10.0 which you can find here.

There are a number of other changes from v0.7.0 but I think they are overall worth the switch, if you haven't taken a look.