davicorreiajr / spotify-now-playing

Spotify now playing information and control popup for macOS menu bar
MIT License
217 stars 11 forks source link

Notifications, security, and editorial changes #56

Closed paced closed 2 years ago

paced commented 3 years ago

What does this PR do?

Is this a bugfix or an improvement?;

Both.

Explain the changes this PR brings to the project;

Mention a issue (adding the link, of course) if there is any relationship;

Closes #40.

Insert some print screen of the result, if it changes the UI.

image

How to test?

Explain how to test in localhost and/or with the build app (what to do, which songs if necessary, etc).

Standard flow works fine.

Critical points

Is there any part of the code that deserves more attention?;

This repository does not seem maintained. I'd love to see it improve until Spotify implements their own notifications for macOS.

Hopefully I'm not overstepping here, but I'd suggest one of:

Any technical debt produced by this code? Something could be done better but it wasn't? Why?.

Not that I can see.

paced commented 2 years ago

Codebases are now too different to accept a pull request