Closed paced closed 2 years ago
Is this a bugfix or an improvement?;
Both.
Explain the changes this PR brings to the project;
Mention a issue (adding the link, of course) if there is any relationship;
Closes #40.
Insert some print screen of the result, if it changes the UI.
Explain how to test in localhost and/or with the build app (what to do, which songs if necessary, etc).
Standard flow works fine.
Is there any part of the code that deserves more attention?;
This repository does not seem maintained. I'd love to see it improve until Spotify implements their own notifications for macOS.
Hopefully I'm not overstepping here, but I'd suggest one of:
Any technical debt produced by this code? Something could be done better but it wasn't? Why?.
Not that I can see.
Codebases are now too different to accept a pull request
What does this PR do?
Is this a bugfix or an improvement?;
Both.
Explain the changes this PR brings to the project;
Mention a issue (adding the link, of course) if there is any relationship;
Closes #40.
Insert some print screen of the result, if it changes the UI.
How to test?
Explain how to test in localhost and/or with the build app (what to do, which songs if necessary, etc).
Standard flow works fine.
Critical points
Is there any part of the code that deserves more attention?;
This repository does not seem maintained. I'd love to see it improve until Spotify implements their own notifications for macOS.
Hopefully I'm not overstepping here, but I'd suggest one of:
Any technical debt produced by this code? Something could be done better but it wasn't? Why?.
Not that I can see.