david-barnett / microViz

R package for microbiome data visualization and statistics. Uses phyloseq, vegan and the tidyverse. Docker image available.
https://david-barnett.github.io/microViz/
GNU General Public License v3.0
94 stars 10 forks source link

fix bug allowing lmer to work in tax_model #52

Closed david-barnett closed 1 year ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #52 (aadb2a6) into main (07f1fdb) will increase coverage by 8.12%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   61.90%   70.02%   +8.12%     
==========================================
  Files          66       66              
  Lines        4407     4407              
==========================================
+ Hits         2728     3086     +358     
+ Misses       1679     1321     -358     
Impacted Files Coverage Δ
R/tax_model.R 69.64% <100.00%> (ø)
R/ord_plot.R 82.80% <0.00%> (+0.63%) :arrow_up:
R/comp_barplot.R 93.70% <0.00%> (+2.79%) :arrow_up:
R/ps_extra-accessors.R 57.69% <0.00%> (+7.69%) :arrow_up:
R/ord_explore.R 82.54% <0.00%> (+33.90%) :arrow_up:
R/tax_fix_interactive.R 100.00% <0.00%> (+53.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07f1fdb...aadb2a6. Read the comment docs.

SilasK commented 1 year ago

Hello, I would also be interested in this feature. Is it abandoned?

SilasK commented 1 year ago

It seems one can now specify lmer as type?

david-barnett commented 1 year ago

yep the bug that prevented lmer use is fixed in main branch a while ago, but I still have not tested whether outputting lmerMod models would play nice with other microViz tax* functions.

I suspect some weird behaviour will arise somewhere if you try, but a quick google suggests broom.mixed package might provide a sane way forward. i.e loading broom.mixed should allow tax_models2stats to work with lmer output...

anyway, if you try it, I'm happy to hear about your experiences and issues, and such feedback would make proper integration of mixed effects model support in microViz more likely 🙂