search

david-c14 / ModularFungi

Omri Cohen's Modular Fungi for VCVRack
BSD 3-Clause "New" or "Revised" License
12 stars 9 forks source link

Lights Off doesn't seem to be doing anything on Mac OS X #13

Closed pgatt closed 3 years ago

pgatt commented 4 years ago

Hi there, Lights off doesn't seem to be working here. Mac OS X 10.14.6, Rack 1.1.6. Tried using the shortcut and manually changing the dimness, to no avail.

nay-seven commented 4 years ago

For info, same config here (Mac OS X 10.14.6, Rack 1.1.6.) and it works, but i need to use CTRL+Alt+X, not CMD+Alt+X ;-)

pgatt commented 4 years ago

@nay-seven can now confirm that. I thought I had tried most combinations. Ctrl Alt X works.

nay-seven commented 4 years ago

good news

david-c14 commented 4 years ago

@stoermelder

david-c14 commented 4 years ago

The key matching should probably be done against RACK_MOD_CTRL rather than GLFW_MOD_CONTROL

The text on the menu item can also use a macro so that it can be OS specific RACK_MOD_CTRL_NAME

stoermelder commented 4 years ago

@nay-seven can now confirm that. I thought I had tried most combinations. Ctrl Alt X works.

Ok thanks, I will correct the label in the context menu.

MackenMations commented 4 years ago

Hi, I'm also running Rack 1.1.6 on Mac OS X 10.14.6, but for some reason neither CTRL nor CMD +ALT+X work for me. Can't seem to figure it out...?

MackenMations commented 4 years ago

Any suggestions?

stoermelder commented 4 years ago

Which language layout does your keyboad have?

MackenMations commented 4 years ago

It's a Finnish Keyboard, and most of the time I use that layout, but changing to the British layout doesn't do anything.

stoermelder commented 3 years ago

Can anyone confirm that the fix I applied enables the module to work on Mac OS? I can't verify because I had no problems with the hotkey in the first place (except for the Cmd/Alt confusion). You need to build the plugin from the dev branch for testing.

stoermelder commented 3 years ago

I'm closing this issue. If anyone has further problems please comment or open a new issue.

MackenMations commented 3 years ago

Hi, Yes, this now works on Mac OS X. Many thanks.

On Sun, 12 Jul 2020, 11:59 Ben, notifications@github.com wrote:

Can anyone confirm that the fix I applied enables the module to work on Mac OS? I can't verify because I had no problems with the hotkey in the first place (except for the Cmd/Alt confusion). You need to build the plugin from the dev branch for testing.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/david-c14/ModularFungi/issues/13#issuecomment-657193937, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH27YG4OSMQW6H4MHLTNR5TR3F3PJANCNFSM4N2FPLGA .