david-c14 / ModularFungi

Omri Cohen's Modular Fungi for VCVRack
BSD 3-Clause "New" or "Revised" License
12 stars 9 forks source link

Lights Off hides translucent lit widgets, as implemented in Darius or Infix #15

Closed AriaSalvatrice closed 2 years ago

AriaSalvatrice commented 4 years ago

image

image

Tested on Windows 10. To reproduce, just add Darius or Infix to the rack. Those widgets are made with semi-transparent SVG overlaid over a light the same size.

Relevant bits from Darius: https://github.com/AriaSalvatrice/AriaVCVModules/blob/d70f0094a3c2b565ebcf0c5b0c0ee66948cf8bb1/src/AriaComponents.hpp#L70 https://github.com/AriaSalvatrice/AriaVCVModules/blob/d70f0094a3c2b565ebcf0c5b0c0ee66948cf8bb1/src/Darius.cpp#L411

stoermelder commented 4 years ago

Yes, you are right. I need to think about a solution for this issue.

AriaSalvatrice commented 4 years ago

People have detailed techniques to make lights off compatible widgets in this thread

https://community.vcvrack.com/t/how-much-do-you-care-about-the-visual-design-of-rack-modules/10460/31

david-c14 commented 4 years ago

Yes. They have done it by changing their modules to be compatible with Lights Off. Rather than the other way round.

I don't think it would be a simple change for Darius, I think you would have to create custom widgets which descended from both PortWidget and LightWidget, and then override the draw method. Although you might be able to just call both of the base class Draw methods one after the other.

AriaSalvatrice commented 4 years ago

Another forum thread here now: https://community.vcvrack.com/t/modules-that-work-with-modular-fungi-lightsoff/10477

stoermelder commented 4 years ago

@AriaSalvatrice I fixed it in my modules by "cutting out" the area covered by port from the light. This might not be doable in every case but it did it for my modules. https://github.com/stoermelder/vcvrack-packone/blob/b82f19df8e7ce267a5ef4694db0f2ac06fa6ccdb/src/components.hpp#L279

david-c14 commented 2 years ago

Development for Modular Fungi is currently on hold.

Lights off functionality is now managed within VCVRack v2. So changes to the v1 of Modular Fungi is now unlikely.