Scope performance and external window

david-c14 / ModularFungi

Omri Cohen's Modular Fungi for VCVRack

BSD 3-Clause "New" or "Revised" License

12 stars 9 forks source link

Scope performance and external window #26

Closed curlymorphic closed 4 years ago

curlymorphic commented 4 years ago

Improved the performance of the Scope plugin
- Added options to the context menu for performance varying the size of buffer hence the number of points plotted.
Moved the line type and plot type parameters from the context menu to knobs and cv inputs on the widget
- Interpolation between linetypes
- Added external window for plotting. When external window open the widget no longer renders the waveform in the VCV ui

@david-c14

I am unsure if your intention is for me to merge, prepare the release, and submit to the VCV library?

david-c14 commented 4 years ago

@curlymorphic You can do that if you wish. I own this project purely for historical reasons, and have no wish to be dictatorial or even proprietorial.

If you would prefer me to manage that side of things, I will. In which case just let me know in comments if you think that a push deserves submitting to the library, or if there might be further changes in the future so we should wait.

But I'm entirely happy if you want to complete and submit yourself. You can easily find the appropriate library issue by searching for ModularFungi.

david-c14 commented 4 years ago

If I'm making the last changes before a new release, I usually include the change to plugin.json in the same work. But sometimes I just make a separate PR for it called something like 'preparing for release 1.x.x'

david-c14 commented 4 years ago

I usually merge from develop to main using a PR as well.

Then create a release from the main branch. This will trigger github actions which will build for all three platforms and attach the zips to the release.

curlymorphic commented 4 years ago

@david-c14 Thanks for the advice, I shall proceed with the release process