search

david-c14 / ModularFungi

Omri Cohen's Modular Fungi for VCVRack
BSD 3-Clause "New" or "Revised" License
12 stars 9 forks source link

LightsOff may miss transformations which are applied to LightWidgets #35

Closed david-c14 closed 2 years ago

david-c14 commented 3 years ago

When LightsOff searches the widget tree to find LightWidgets, it has no way of handling the situation where a parent widget has transformed the nvgContext.

I.e. if in the normal drawing sequence a widget transforms the coordinate system of the context, which is then passed to it's child widgets, including potentially LightWidgets, this transformation is missing when the LightWidget is rendered separately in LightsOff mode. Only the rack's global zoom and pan transforms are applied.

david-c14 commented 3 years ago

I can't see a realistic approach to fixing that.

david-c14 commented 3 years ago

By way of a concrete example. A Widget with a child that is a ZoomWidget or a TransformWidget. And that has a child which is some descendent of LightWidget will render one way with the lights on, and differently with the lights off.

david-c14 commented 2 years ago

Development for Modular Fungi is currently on hold.

Lights off functionality is now managed within VCVRack v2. So changes to the v1 of Modular Fungi is now unlikely.