Improve foreman/api version detection/usage

david-caro commented 10 years ago

Right now only foreman version is detected, but in a short time the new api version 2 will be out and we should be able to let the user choose also.

ekohl commented 10 years ago

V2 also supports more complex URLs such as /api/hosts/:host/power with a PUT to set the power state. That would mean more complex objects which support actions.

ghost commented 10 years ago

+1

there is another issue version detection fails

using with foreman 1.3 and foreman.client when im creating the api object without version spec, getting this exception: ForemanVersionException: Unable to get version

when version specified like this: f = Foreman('https://x', auth=('x', 'x'), version='1.3') it works as excepted.

Regards, Eldad

david-caro commented 10 years ago

emarcian: I have created issue #10 to take care of that. Can you please specify there which version of foreman are you using (1.3.0?). I have just tested foreman 1.3.2 and 1.3.1 and it worked for me. I'd like to investigate it further.

ghost commented 10 years ago

Hi, working on 1.3.1

----- Original Message -----

From: "David" notifications@github.com To: "david-caro/python-foreman" python-foreman@noreply.github.com Cc: "emarcian" emarcian@redhat.com Sent: Thursday, January 16, 2014 10:14:02 PM Subject: Re: [python-foreman] Improve foreman/api version detection/usage (#2)

emarcian: I have created issue #10 to take care of that. Can you please specify there which version of foreman are you using (1.3.0?). I have just tested foreman 1.3.2 and 1.3.1 and it worked for me. I'd like to investigate it further.

— Reply to this email directly or view it on GitHub .

david-caro commented 10 years ago

A major rewrite has been pushed, can you retest? Open a new issue with the version detection failure if still relevant, thanks!

david-caro / python-foreman

Improve foreman/api version detection/usage #2