search

david-caro / python-foreman

Small low level python wrapper around Foreman API
GNU General Public License v2.0
57 stars 37 forks source link

Parameters to set timeout by request method, higher default for POST and DELETE #39

Closed fpytloun closed 9 years ago

fpytloun commented 9 years ago

It's not a good idea to set low default timeout for POST and DELETE requests as these may take a long time, depending on compute resource and how deployment works in given environment.

10 minute timeout for POSTs and DELETEs should be safe enough. User can set these timeouts to None (default timeout) or 0 (no timeout for given method).

It's a pitty that these Foreman resources are not asynchronous.

david-caro commented 9 years ago

I have to verify before merge but looks ok

fpytloun commented 9 years ago

Thank you! :-)

david-caro commented 9 years ago

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512

You are welcome :)

On May 1, 2015 11:58:39 AM GMT+02:00, Filip Pytloun notifications@github.com wrote:

Thank you! :-)

Reply to this email directly or view it on GitHub: https://github.com/david-caro/python-foreman/pull/39#issuecomment-98087375

Sent from my Android device with K-9 Mail through Mykolab servers. -----BEGIN PGP SIGNATURE----- Version: APG v1.1.1

iQFLBAEBCgA1BQJVQ4ptLhxEYXZpZCBDYXJvIChSZWRIYXQga2V5KSA8ZGNhcm9l c3RAcmVkaGF0LmNvbT4ACgkQQHHH4dJiacNj0Af9G4m01kZPpPr9QgBCMVko3Rw2 bUCrjgBs8q+1JltW5kQT6natKX/lB4g8c9yfKFwwzFrgNp8tAfkXBTyjVYU8tsul CBHv+fn1F1fLsdRpxvkHfnMnfEuSD/nJVVZh9uXpjLbkgroA2UtwTvR6as+vjSiq AHLZuAEY547rnf34v7WaX9cptpCSAoxvWl2nOnuqf0r4Xu4t/GPGTt9Pn0mDGKoy /4SjWrrXWKQpDAc5DaFT3VmQg0OOGnAPpiDcMX74gBvVzYvcHa7QJTn4pOlkfC/D lc+GCacDB90vtCxPbRSyNyL4FjPVacczuLLmz49YbiKK1xWK2xvoLn6ck2e22A== =JBx1 -----END PGP SIGNATURE-----