Use do_get() for get_foreman_version() and _get_remote_defs() as well

david-caro / python-foreman

Small low level python wrapper around Foreman API

GNU General Public License v2.0

58 stars 37 forks source link

Use do_get() for get_foreman_version() and _get_remote_defs() as well #46

Closed pief closed 9 years ago

pief commented 9 years ago

The two methods used to call self.session.get() directly, thereby ignoring configured timeouts.

pief commented 9 years ago

Second commit slipped in by accident, closing and reopening a new PR.

Ichimonji10 commented 9 years ago

@pief Try reading up on git rebase and git commit --amend. You can rewrite the history of absolutely any branch in git - and therefore fix any PR - instead of creating all these throw-away pull requests.