search

david-caro / python-foreman

Small low level python wrapper around Foreman API
GNU General Public License v2.0
58 stars 37 forks source link

Use do_get() for get_foreman_version() and _get_remote_defs() as well #51

Closed pief closed 9 years ago

pief commented 9 years ago

The two methods used to call self.session.get() directly, thereby ignoring configured timeouts.

pief commented 9 years ago

Sorry, for opening another PR, problem was I didn't use a separate branch for this change.

In any case, it turns out the behavior I observed in #47 are actually caused by this change. I'll do some more testing to investigate.

pief commented 9 years ago

I didn't see that do_get() does additional magic with interpreting a request's response, so I instead opted for simply amending the self.session.get() calls with the timeout parameter.

This should now be ready for review.