search

david-caro / python-foreman

Small low level python wrapper around Foreman API
GNU General Public License v2.0
57 stars 37 forks source link

Suppress API resource redefinition warnings for repeated definitions #54

Closed pief closed 8 years ago

pief commented 8 years ago

The JSON definitions retrieved from a Foreman instance could contain repeated but identical method definitions (this was eg. the case for Foreman 1.7.5.). No need to log a warning here since this behavior doesn't have any actual negative effect.

david-caro commented 8 years ago

Actually I don't think we should just ignore them, but adding a proper logging leveling (and showing the duplicated issues only on debug for example). As a duplicated definition is actually an error in foreman.

david-caro commented 8 years ago

I've opened another PR changing the logging level instead, does that work for you?

opened: #56

pief commented 8 years ago

Considering this PR obsolete because of #56 and #63, closing.