david-caro / python-foreman

Small low level python wrapper around Foreman API
GNU General Public License v2.0
57 stars 37 forks source link

Unhandled TypeError exception on cache dir creation failure #67

Open jcmcken opened 8 years ago

jcmcken commented 8 years ago

This line leads to an unhandled TypeError in this line (TypeError: 'NoneType' object is unsubscriptable).

Perhaps it should log an error instead, and continue to return the data (so the remote defs would be loaded every time, and not cached locally, but at least the client operation would potentially still succeed)?

david-caro commented 8 years ago

I think that the return you point out should return data instead of null yes

jcmcken commented 8 years ago

Sorry about the spam, clearly haven't had enough caffeine today