search

david-caro / python-foreman

Small low level python wrapper around Foreman API
GNU General Public License v2.0
57 stars 37 forks source link

Missing tags? #74

Closed sdodson closed 7 years ago

sdodson commented 7 years ago

I can't find 0.4.1, 0.4.5, 0.4.11, 0.4.12 tags. Have they by chance not been pushed up to github?

david-caro commented 7 years ago

Not every version or release has a tag, but every commit has a different version. You can check the changelog to see which commits match which versions, if you have the git code, you can check with the version_manager.py script, running scripts/version_manager.py . changelog.

Cheers

sdodson commented 7 years ago

So, how do I work back from 0.4.11 to the commit it references? Do I just take the most recent hash in a given changelog entry? in this case 3f6234e7 or 34eab999?

$ scripts/version_manager.py . changelog
...
* 0.4.11 "David Caro <david@dcaro.es>"
    MINOR 3f6234e7: Merge pull request #73 from david-caro/remove_pbr
    MINOR 34eab999: packaging: deprecate py26 and move to setuptools
david-caro commented 7 years ago

You should take the merge commit there, the others are commits that are included on it (for the versioning it only takes into account the main parents path).

david-caro commented 7 years ago

Specifically in this case 3f6234e7. Completely agree though that it's not very clear, I will try to change the way the changelog is generated to make that more visible ;)

sdodson commented 7 years ago

Awesome, thanks!