search

david-caro / python-foreman

Small low level python wrapper around Foreman API
GNU General Public License v2.0
57 stars 37 forks source link

SSL 'verify' should be stored in 'self._req_params' #91

Closed papamoose closed 6 years ago

papamoose commented 6 years ago

The usage of self._req_params was inconsistent. I made SSL verify global, which is what I believe was intended in commit de54bfd5d63e7a52a02113de35de59b8be117366.

Without this change, the function _get_remote_defs() is not able to make an insecure connection, even if you had set verify=False.

Instead of adding verify=self.session.verify, to _get_remote_defs() we just add verifys value to the dictionary.

papamoose commented 6 years ago

Bump. Can someone take a look at this pull request?

david-caro commented 6 years ago

Thanks for the PR, it looks ok to me, I'll get the test issues fixed and merge (they are due to pep8 changes, unrelated to your change).