david-cattermole / mayaMatchMoveSolver

A Bundle Adjustment solver for MatchMove related tasks.
https://david-cattermole.github.io/mayaMatchMoveSolver/
Other
101 stars 29 forks source link

Allow Users to Disable the Auto-Adding Markers to the Active Collection #164

Closed david-cattermole closed 3 years ago

david-cattermole commented 3 years ago

Problem / Feature

Users want to be able to disable (or enable) the feature from #138, so that newly created Markers are not added to the active Collection.

The ability to enable/disable automatically adding Markers to Collections is not a feature of Collections, or the Solver UI. Instead the feature is determined at the basis of mmSolver.

This calls for a kind of "Preference option" that the user may want to change. Other preferences may also exist in mmSolver and these should be documented and be settable as well.

Software Versions

RodeoPerchaude commented 3 years ago

First ever post on github for me! (I am Etienne from RodeoFx) I will try to get involved with mmsolver git board, thanks for considering my suggestions and keep on the awesome work.

Hello David, thanks for looking into that, adding markers to active collection would be a great option to add to the load marker tool instead of making #138 the default behavior.

david-cattermole commented 3 years ago

Hello Etienne,

That's not a bad idea. I could add another drop-down box to the Load Markers UI which automatically adds the marker to the specified Collection. By default the drop-down menu would use the active Collection.

I think it's still a good idea to have a preference that users can set, but this Loader Markers UI would override that option and place the marker into the specific Collection that was requested by the user.

What do you think?

David

david-cattermole commented 3 years ago

Hello @RodeoPerchaude,

I have added a User Preferences window, and an underlying user preferences library to control the behaviour of "Add New Markers To".

You can find the tool in the mmSolver > General Tools > User Preferences... shelf button. image

The window is currently quite empty except for the one preference: image

This update will also temporarly disable "Add New Markers To" from running when using the Load Markers tool, even if the user preference has turned the option on. Users must manually apply the Markers to the collection of their choosing, until I can add a feature to the Load Markers UI to automate this.

This will be released in v0.3.9, hopefully this weekend.

David

RodeoPerchaude commented 3 years ago

Thanks a lot @david-cattermole .

I will definitely use this feature.

david-cattermole commented 3 years ago

This will be released shortly in v0.3.9.

Closing for now.