david-cattermole / mayaMatchMoveSolver

A Bundle Adjustment solver for MatchMove related tasks.
https://david-cattermole.github.io/mayaMatchMoveSolver/
Other
101 stars 29 forks source link

Don't stop solves with some invalid sub-solves, only skip invalid solves #166

Closed david-cattermole closed 3 years ago

david-cattermole commented 3 years ago

Problem / Feature

When a solve does not have enough markers on at least one frame, mmSolver will currently stop the entire solve from running, even if only one frame is not working.

I propose we simply skip the invalid solves, rather than stopping all of them. This will simplify solves when multiple markers are turning on/off on many frames.

Expected behavior: When a solve with 100 frames has a single frame solve's validation failed, all other 99 frames should still solve, only skipping the single frame.

Actual behavior: When a solve with 100 frames has a single frame solve's validation failed, mmSolver will not solve any of the frames.

Software Versions

david-cattermole commented 3 years ago

This will be released in v0.3.9.